Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed radar upload backend network policy #297

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fixed radar upload backend network policy #297

merged 1 commit into from
Nov 11, 2024

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Nov 7, 2024

Since we reuse PostgreSQL chart and change its name, the selector label also needs to change to match that.

  labels:
    app.kubernetes.io/component: primary
    app.kubernetes.io/instance: radar-upload-postgresql
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: postgresql
    apps.kubernetes.io/pod-index: "0"
    controller-revision-hash: radar-upload-postgresql-7c65bcc55c
    helm.sh/chart: postgresql-12.1.9
    statefulset.kubernetes.io/pod-name: radar-upload-postgresql-0

@keyvaann keyvaann requested a review from pvannierop November 7, 2024 16:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

pvannierop
pvannierop approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit unclear how this works, but I assume you have figured this out. LGTM.

@pvannierop pvannierop merged commit f12df50 into main Nov 11, 2024
5 checks passed
@keyvaann keyvaann deleted the fix-radar-upload-network-policy branch November 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvannierop pvannierop pvannierop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyvaann @pvannierop